-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #50722 upstream release 1.7 #51079
Automated cherry pick of #50722 upstream release 1.7 #51079
Conversation
Fix for Policy based volume provisioning failure due to long VM Name in vSphere cloud provider kubernetes#50722
Hi @rohitjogvmw. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @mikedanese |
cherrypick-approved keyword is not available. |
/approve. Can some add cherry-pick label on this PR. Its missing on this PR. |
@BaluDontu @rohitjogvmw -if you want this cherrypicked, please add a (user-oriented) release note for the original PR. |
I have added release notes to #50722 |
@wojtek-t can you please see if all required things are now available correctly? |
/ok-to-test |
/approve |
@BaluDontu @luomiao - please LGTM this |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: luomiao, rohitjogvmw, wojtek-t Associated issue: 50722 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/retest |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
Cherry pick of #50722 on release-1.7:
#50722: Fix for Policy based volume provisioning failure due to long VM Name in vSphere cloud provider
@BaluDontu @divyenpatel @tusharnt @luomiao